commit e3aa9cf9df1a02648cfcb25900d151c2d128db73
parent 73783574792a8dc9538b0e20cd61f3177124f897
Author: Laurent Bercot <ska-skaware@skarnet.org>
Date: Thu, 19 Feb 2015 22:35:50 +0000
- Bugfix: unixmessage_sender_init didn't initialize b->shorty
- byte_zero the ancilbuf's padding to appease valgrind
Diffstat:
2 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/src/libunixonacid/unixmessage_sender_flush.c b/src/libunixonacid/unixmessage_sender_flush.c
@@ -8,6 +8,7 @@
#include <errno.h>
#include <skalibs/uint16.h>
#include <skalibs/uint32.h>
+#include <skalibs/bytestr.h>
#include <skalibs/diuint.h>
#include <skalibs/allreadwrite.h>
#include <skalibs/genalloc.h>
@@ -82,6 +83,7 @@ int unixmessage_sender_flush (unixmessage_sender_t *b)
{
struct cmsghdr *cp = CMSG_FIRSTHDR(&hdr) ;
register unsigned int i = 0 ;
+ byte_zero(ancilbuf, sizeof(ancilbuf)) ;
cp->cmsg_level = SOL_SOCKET ;
cp->cmsg_type = SCM_RIGHTS ;
cp->cmsg_len = CMSG_LEN(nfds * sizeof(int)) ;
diff --git a/src/libunixonacid/unixmessage_sender_init.c b/src/libunixonacid/unixmessage_sender_init.c
@@ -11,4 +11,5 @@ void unixmessage_sender_init (unixmessage_sender_t *b, int fd)
b->fds = genalloc_zero ;
b->offsets = genalloc_zero ;
b->head = 0 ;
+ b->shorty = 0 ;
}