skalibs

commit dd478a768bce79bcf6c627310e2ddb473667fecc
parent 540cefac9d8e663dfb3ad69b0bb806a9ba5e88b4
Author: Laurent Bercot <ska-skaware@skarnet.org>
Date:   Mon, 10 Feb 2020 19:18:54 +0000

 bugfix: env_merge didn't correctly handle variable removal

Diffstat:
M
AUTHORS
 | 
1
+
M
src/libstddjb/env_merge.c
 | 
3
++-

2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/AUTHORS b/AUTHORS
@@ -36,3 +36,4 @@ Thanks to:
   Johannes Nixdorf <mixi@shadowice.org>
   Casper Ti. Vector <caspervector@gmail.com>
   Guillermo <gdiazhartusch@gmail.com>
+  Alex Raschi <raschi.alex@gmail.com>
diff --git a/src/libstddjb/env_merge.c b/src/libstddjb/env_merge.c
@@ -16,7 +16,8 @@ size_t env_merge (char const **v, size_t vmax, char const *const *envp, size_t e
   {
     size_t split = str_chr(modifs + i, '=') ;
     size_t j = 0 ;
-    for (; j < vlen ; j++) if (!strncmp(modifs + i, v[j], split+1)) break ;
+    for (; j < vlen ; j++)
+      if (!strncmp(modifs + i, v[j], split) && (v[j][split] == '=')) break ;
     if (j < vlen) v[j] = v[--vlen] ;
     if (modifs[i + split]) v[vlen++] = modifs + i ;
   }